Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Complete the protocol testing skeleton #28

Merged
merged 7 commits into from
Jan 22, 2018

Conversation

qiuzhong
Copy link
Collaborator

Add a complete rosbridge v2 protocol test case to implement the testing scenario.

* Split the tests into two parts: pure Node.js test cases in node.js directory
  and browser test cases in browser directory.
* Set up the puppeteer environment for Travis CI.
* Add a sanity test for CI validation
* Add a JSON format file to specify the html pages for browser
  testing so we need not pass them to the command line.
* Move the dependencies packages used in browser testing to the
  devDependencies field in package.json.
Add a complete rosbridge v2 protocol test case to implement the
testing scenario.
Copy link
Member

@minggangw minggangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the patch!

@minggangw minggangw merged commit 8d7ffe0 into RobotWebTools:develop Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants