Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug that ApInt::sign_bit only works for bit widths of multiples of 64. #9

Closed
Robbepop opened this issue Dec 24, 2017 · 1 comment
Closed

Fix bug that ApInt::sign_bit only works for bit widths of multiples of 64. #9

Robbepop opened this issue Dec 24, 2017 · 1 comment
Labels
bug

Comments

@Robbepop
Copy link
Owner

ApInt::sign_bit always returns the most significant bit of the most significant digit of the ApInt which is wrong since Digit does not know about the bit width of an ApInt and thus this calculation only works for bit widths that are multiples of the exact Digit bit width which is 64. ApInt::most_significant_bit has the same error.
@Robbepop Robbepop added the bug label Dec 24, 2017
Robbepop added a commit that referenced this issue Dec 24, 2017
@Robbepop
Refactored ApInt::least_significant_bit and reimplemented and fixed…
fcedb3f 
… a bug in `ApInt::most_significant_bit`. This commit fixes GitHub issue #9.
@Robbepop
Copy link
Owner Author

Fixed in commit fcedb3f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Robbepop