Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use even/odd TLV numbers everywhere #43

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

guggero
Copy link

@guggero guggero commented Oct 4, 2023

Syncs the TLV numbers with the current code.

Copy link
Owner

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🗞️

@@ -231,8 +231,8 @@ verify_taproot_asset_state_transition(leaf: TaprootAssetLeaf, leaf_split: Taproo
case AssetID:
if input.asset_id != leaf.asset_id:
return false
case KeyFamily:
if input.asset_key_family != leaf.asset_key_family:
case GroupKey:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Roasbeef Roasbeef merged commit 666d60e into Roasbeef:bip-tap-pr Oct 10, 2023
3 checks passed
@guggero guggero deleted the tlv-re-numbering branch October 10, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants