Use largest available preview size from android camera #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses cordova-plugin-camera-preview#53. Solution adapted from comment cordova-plugin-camera-preview#53 (comment).
| @@ -719,6 +719,22 @@ public void surfaceDestroyed(SurfaceHolder holder) { | |||
| return optimalSize; | |||
| } | |||
|
|
|||
| private Camera.Size getLargestPreviewSize(List<Camera.Size> sizes, int w, int h) { | |||
There was a problem hiding this comment.
Looks like we not doing anything with w and h ?
Does the purpose of optimal size is to get closed camera size to requested ?
I think we should compare sizes.get(i).width > w starting with smallest.
There was a problem hiding this comment.
Looks like we not doing anything with w and h ?
Correct, it would be safe to remove.
Does the purpose of optimal size is to get closed camera size to requested ?
No, that's what the original method - getOptimalPreviewSize() - does. This gets the largest preview (by width) available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses cordova-plugin-camera-preview#53. Solution adapted from comment
cordova-plugin-camera-preview#53 (comment).