Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Rename to_json functions into to_dict #174

Open
rnikoopour opened this issue Jul 16, 2018 · 0 comments
Open

Rename to_json functions into to_dict #174

rnikoopour opened this issue Jul 16, 2018 · 0 comments

Comments

@rnikoopour
Copy link
Contributor

Functions exist in the code base that are called to_json. These functions are misleading because they create dicts not json strings.

We should either rename the functions from to_json into to_dict or have the to_json functions return json strings.
@rnikoopour rnikoopour mentioned this issue Jul 16, 2018
Merged
Aretusa added a commit to Aretusa/cloud-inquisitor that referenced this issue Aug 7, 2018
@Aretusa
Change "to_json" into "to_dict"
3b58c8c 
I changed the definition "to_json" into "to_dict" since it returns a json "friendly" dict. This change was requested in issue RiotGames#174.
@Aretusa Aretusa mentioned this issue Aug 8, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rnikoopour