Another fix to the Buffer SaveStates #2369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the tests for the Buffer SaveStates and noticed another issue with it, and this PR fixes that issue.
So with my galaxy sized brain (implied sarcasm, btw), in the save/restore code for 8-bit buffers, I forgot that not all numbers are divisible by 4, so Iceman fixed that flaw. In doing so, the outputted size of the buffer was bigger than the original size, causing issues when reconstructing data. I modified the
buffer_savestate_t
structs to have aconst uint8_t padding
which keeps track of any padding that is needed for restoring the buffer. Now, no matter what buffer goes in, it comes out correctly and is the right sized.