Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIFFS: implement dumping from SPIFFS to client trace buffer #2217

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

hazardousvoltage
Copy link
Contributor

Sometimes one has a bunch of traces in SPIFFS after a long day of standalone work, and wants to look at them and decide what to save. Adds '-t' option to mem spiffs dump, to download the data into client trace buffer instead of creating a local file which one must then 'trace load'

Not sure I like how I implemented this, or whether it's useful to anyone else.

Copy link

You are welcome to add an entry to the CHANGELOG.md as well

@iceman1001
Copy link
Collaborator

Cool,

Only thing I see is that -t vs -s is excluding, when you can use "-t" and "-s" at the same time. Save and load graphbuff.

Just check if there was slen and run that part of the code too.

@hazardousvoltage
Copy link
Contributor Author

Hi, thanks for the comments..

-t does not exclude -s, it's excluding -d

Perhaps better, if -t is used, dump only to tracebuffer, but if used with -d, also save to file?

@iceman1001
Copy link
Collaborator

yeah,

so to make it perfectly clear how it should work,

-t fill trace
-d save to file

if both params, do both. Meaning we can both save to file and load trace.
if only one, it does what that param intends.

@iceman1001 iceman1001 merged commit 6d34bbf into RfidResearchGroup:master Jan 2, 2024
12 checks passed
@iceman1001
Copy link
Collaborator

Ignore my comments, this way works well.

Thanks!

@hazardousvoltage hazardousvoltage deleted the work branch May 21, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants