improve PausedSocketFix, Fix peerIdsQueue #549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FirstGearGames
commented
Apr 26, 2024
FirstGearGames
commented
- Added PausedSocketFix usage is now optional via NetManager ctor. Default set to use.
- Fixed peer Ids not returning to _peerIdsQueue.
- Improved queue usage to be more flexible with other applications.
- Improved added error checking for when no more peerIds are available.
- Changed _lastPeerId to _nextPeerId for clarity.
- Changed UNITY_2018__3_OR_NEWER define related to PausedSocketFix to UNITY_SOCKET_FIX for clarity.
added 2 commits
April 26, 2024 17:13
- Added PausedSocketFix usage is now optional via NetManager ctor. Default set to use. - Fixed peer Ids not returning to _peerIdsQueue. - Improved queue usage to be more flexible with other applications. - Improved added error checking for when no more peerIds are available. - Changed _lastPeerId to _nextPeerId for clarity. - Changed UNITY_2018__3_OR_NEWER define related to PausedSocketFix to UNITY_SOCKET_FIX for clarity.
FirstGearGames
commented
Apr 26, 2024
Changed addable check for peerIds to <= 0 rather than 0.
FirstGearGames
commented
Apr 26, 2024
|
Can you separate please PeerIds commit and PausedSocketFix? |
Yeah absolutely. It might take me a couple days(maybe not), but I will. |
|
Closing this to make separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.