MM-10074 - Updating modal title markup (mattermost#2790)

Revanth47 · May 14, 2019 · 6111a59 · 6111a59
1 parent 505eaa6
commit 6111a59
Show file tree

Hide file tree

Showing 72 changed files with 249 additions and 129 deletions.
diff --git a/components/__snapshots__/list_modal.test.jsx.snap b/components/__snapshots__/list_modal.test.jsx.snap
@@ -36,7 +36,7 @@ exports[`components/ListModal should match snapshot 1`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  >
  <span
  className="name"
@@ -143,7 +143,7 @@ exports[`components/ListModal should match snapshot with title bar button 1`] =
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  >
  <span
  className="name"

diff --git a/components/__snapshots__/post_deleted_modal.test.jsx.snap b/components/__snapshots__/post_deleted_modal.test.jsx.snap
@@ -35,7 +35,7 @@ exports[`components/ChannelInfoModal should match snapshot when modal is not sho
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="postDeletedModalLabel"
  >
  <FormattedMessage
@@ -112,7 +112,7 @@ exports[`components/ChannelInfoModal should match snapshot when modal is showing
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="postDeletedModalLabel"
  >
  <FormattedMessage

diff --git a/components/about_build_modal/__snapshots__/about_build_modal.test.jsx.snap b/components/about_build_modal/__snapshots__/about_build_modal.test.jsx.snap
@@ -36,7 +36,7 @@ exports[`components/AboutBuildModal should match snapshot for enterprise edition
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="aboutModalLabel"
  >
  <FormattedMessage
@@ -280,7 +280,7 @@ exports[`components/AboutBuildModal should match snapshot for team edition 1`] =
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="aboutModalLabel"
  >
  <FormattedMessage
@@ -512,7 +512,7 @@ exports[`components/AboutBuildModal should show ci if a ci build 1`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="aboutModalLabel"
  >
  <FormattedMessage
@@ -756,7 +756,7 @@ exports[`components/AboutBuildModal should show dev if this is a dev build 1`] =
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="aboutModalLabel"
  >
  <FormattedMessage

diff --git a/components/about_build_modal/about_build_modal.jsx b/components/about_build_modal/about_build_modal.jsx
@@ -205,7 +205,10 @@ export default class AboutBuildModal extends React.PureComponent {
  aria-labelledby='aboutModalLabel'
  >
  <Modal.Header closeButton={true}>
- <Modal.Title id='aboutModalLabel'>
+ <Modal.Title
+ componentClass='h1'
+ id='aboutModalLabel'
+ >
  <FormattedMessage
  id='about.title'
  defaultMessage='About Mattermost'

diff --git a/components/access_history_modal/__snapshots__/access_history_modal.test.jsx.snap b/components/access_history_modal/__snapshots__/access_history_modal.test.jsx.snap
@@ -38,7 +38,7 @@ exports[`components/AccessHistoryModal should match snapshot when audits exist 1
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="accessHistoryModalLabel"
  >
  <FormattedMessage
@@ -104,7 +104,7 @@ exports[`components/AccessHistoryModal should match snapshot when no audits exis
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="accessHistoryModalLabel"
  >
  <FormattedMessage

diff --git a/components/access_history_modal/access_history_modal.jsx b/components/access_history_modal/access_history_modal.jsx
@@ -85,7 +85,10 @@ export default class AccessHistoryModal extends React.PureComponent {
  aria-labelledby='accessHistoryModalLabel'
  >
  <Modal.Header closeButton={true}>
- <Modal.Title id='accessHistoryModalLabel'>
+ <Modal.Title
+ componentClass='h1'
+ id='accessHistoryModalLabel'
+ >
  <FormattedMessage
  id='access_history.title'
  defaultMessage='Access History'

diff --git a/components/activity_log_modal/__snapshots__/activity_log_modal.test.jsx.snap b/components/activity_log_modal/__snapshots__/activity_log_modal.test.jsx.snap
@@ -38,7 +38,7 @@ exports[`components/ActivityLogModal should match snapshot 1`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="activityLogModalLabel"
  >
  <FormattedMessage
@@ -106,7 +106,7 @@ exports[`components/ActivityLogModal should match snapshot 2`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="activityLogModalLabel"
  >
  <FormattedMessage
@@ -175,7 +175,7 @@ exports[`components/ActivityLogModal should match snapshot when submitRevoke is
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="activityLogModalLabel"
  >
  <FormattedMessage

diff --git a/components/activity_log_modal/activity_log_modal.jsx b/components/activity_log_modal/activity_log_modal.jsx
@@ -121,7 +121,10 @@ export default class ActivityLogModal extends React.PureComponent {
  aria-labelledby='activityLogModalLabel'
  >
  <Modal.Header closeButton={true}>
- <Modal.Title id='activityLogModalLabel'>
+ <Modal.Title
+ componentClass='h1'
+ id='activityLogModalLabel'
+ >
  <FormattedMessage
  id='activity_log.activeSessions'
  defaultMessage='Active Sessions'

diff --git a/components/add_groups_to_team_modal/__snapshots__/add_groups_to_team_modal.test.jsx.snap b/components/add_groups_to_team_modal/__snapshots__/add_groups_to_team_modal.test.jsx.snap
@@ -36,7 +36,7 @@ exports[`components/AddGroupsToTeamModal should match snapshot 1`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  >
  <FormattedMessage
  defaultMessage="Add New Groups To {teamName} Team"

diff --git a/components/add_groups_to_team_modal/add_groups_to_team_modal.jsx b/components/add_groups_to_team_modal/add_groups_to_team_modal.jsx
@@ -237,7 +237,7 @@ export default class AddGroupsToTeamModal extends React.Component {
  onExited={this.handleExit}
  >
  <Modal.Header closeButton={true}>
- <Modal.Title>
+ <Modal.Title componentClass='h1'>
  <FormattedMessage
  id='add_groups_to_team.title'
  defaultMessage='Add New Groups To {teamName} Team'

diff --git a/components/add_user_to_channel_modal/__snapshots__/add_user_to_channel_modal.test.jsx.snap b/components/add_user_to_channel_modal/__snapshots__/add_user_to_channel_modal.test.jsx.snap
@@ -37,7 +37,7 @@ exports[`components/AddUserToChannelModal should match snapshot 1`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="addChannelModalLabel"
  >
  <FormattedMessage

diff --git a/components/add_user_to_channel_modal/add_user_to_channel_modal.jsx b/components/add_user_to_channel_modal/add_user_to_channel_modal.jsx
@@ -263,7 +263,10 @@ export default class AddUserToChannelModal extends React.Component {
  aria-labelledby='addChannelModalLabel'
  >
  <Modal.Header closeButton={true}>
- <Modal.Title id='addChannelModalLabel'>
+ <Modal.Title
+ componentClass='h1'
+ id='addChannelModalLabel'
+ >
  <FormattedMessage
  id='add_user_to_channel_modal.title'
  defaultMessage='Add {name} to a channel'

diff --git a/components/add_users_to_team/__snapshots__/add_users_to_team.test.jsx.snap b/components/add_users_to_team/__snapshots__/add_users_to_team.test.jsx.snap
@@ -38,7 +38,7 @@ exports[`components/AddUsersToTeam should match snapshot 1`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="addTeamModalLabel"
  >
  <FormattedMessage

diff --git a/components/add_users_to_team/add_users_to_team.jsx b/components/add_users_to_team/add_users_to_team.jsx
@@ -240,7 +240,10 @@ export default class AddUsersToTeam extends React.Component {
  aria-labelledby='addTeamModalLabel'
  >
  <Modal.Header closeButton={true}>
- <Modal.Title id='addTeamModalLabel'>
+ <Modal.Title
+ componentClass='h1'
+ id='addTeamModalLabel'
+ >
  <FormattedMessage
  id='add_users_to_team.title'
  defaultMessage='Add New Members To {teamName} Team'

diff --git a/components/admin_console/manage_roles_modal/manage_roles_modal.jsx b/components/admin_console/manage_roles_modal/manage_roles_modal.jsx
@@ -339,7 +339,10 @@ export default class ManageRolesModal extends React.PureComponent {
  aria-labelledby='manageRolesModalLabel'
  >
  <Modal.Header closeButton={true}>
- <Modal.Title id='manageRolesModalLabel'>
+ <Modal.Title
+ componentClass='h1'
+ id='manageRolesModalLabel'
+ >
  <FormattedMessage
  id='admin.manage_roles.manageRolesTitle'
  defaultMessage='Manage Roles'

diff --git a/components/admin_console/manage_teams_modal/__snapshots__/manage_teams_modal.test.jsx.snap b/components/admin_console/manage_teams_modal/__snapshots__/manage_teams_modal.test.jsx.snap
@@ -36,7 +36,7 @@ exports[`ManageTeamsModal should match snapshot init 1`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="manageTeamsModalLabel"
  >
  <FormattedMessage
@@ -122,7 +122,7 @@ exports[`ManageTeamsModal should save data in state from api calls 1`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="manageTeamsModalLabel"
  >
  <FormattedMessage

diff --git a/components/admin_console/manage_teams_modal/manage_teams_modal.jsx b/components/admin_console/manage_teams_modal/manage_teams_modal.jsx
@@ -216,7 +216,10 @@ export default class ManageTeamsModal extends React.Component {
  aria-labelledby='manageTeamsModalLabel'
  >
  <Modal.Header closeButton={true}>
- <Modal.Title id='manageTeamsModalLabel'>
+ <Modal.Title
+ componentClass='h1'
+ id='manageTeamsModalLabel'
+ >
  <FormattedMessage
  id='admin.user_item.manageTeams'
  defaultMessage='Manage Teams'

diff --git a/components/admin_console/manage_tokens_modal/manage_tokens_modal.jsx b/components/admin_console/manage_tokens_modal/manage_tokens_modal.jsx
@@ -167,7 +167,10 @@ export default class ManageTokensModal extends React.PureComponent {
  aria-labelledby='manageTokensModalLabel'
  >
  <Modal.Header closeButton={true}>
- <Modal.Title id='manageTokensModalLabel'>
+ <Modal.Title
+ componentClass='h1'
+ id='manageTokensModalLabel'
+ >
  <FormattedMessage
  id='admin.manage_tokens.manageTokensTitle'
  defaultMessage='Manage Personal Access Tokens'

diff --git a/...ole/permission_schemes_settings/edit_post_time_limit_modal/edit_post_time_limit_modal.jsx b/...ole/permission_schemes_settings/edit_post_time_limit_modal/edit_post_time_limit_modal.jsx
@@ -86,7 +86,10 @@ export default class EditPostTimeLimitModal extends React.Component {
  <Modal.Header
  closeButton={true}
  >
- <Modal.Title id='editPostTimeModalLabel'>
+ <Modal.Title
+ componentClass='h1'
+ id='editPostTimeModalLabel'
+ >
  <FormattedMessage
  id='edit_post.time_limit_modal.title'
  defaultMessage='Configure Global Edit Post Time Limit'

diff --git a/components/admin_console/reset_email_modal/reset_email_modal.jsx b/components/admin_console/reset_email_modal/reset_email_modal.jsx
@@ -98,7 +98,10 @@ export default class ResetEmailModal extends React.Component {
  aria-labelledby='resetEmailModalLabel'
  >
  <Modal.Header closeButton={true}>
- <Modal.Title id='resetEmailModalLabel'>
+ <Modal.Title
+ componentClass='h1'
+ id='resetEmailModalLabel'
+ >
  {title}
  </Modal.Title>
  </Modal.Header>

diff --git a/components/admin_console/reset_password_modal/reset_password_modal.jsx b/components/admin_console/reset_password_modal/reset_password_modal.jsx
@@ -166,7 +166,10 @@ export default class ResetPasswordModal extends React.Component {
  aria-labelledby='resetPasswordModalLabel'
  >
  <Modal.Header closeButton={true}>
- <Modal.Title id='resetPasswordModalLabel'>
+ <Modal.Title
+ componentClass='h1'
+ id='resetPasswordModalLabel'
+ >
  {title}
  </Modal.Title>
  </Modal.Header>

diff --git a/components/change_url_modal/__snapshots__/change_url_modal.test.jsx.snap b/components/change_url_modal/__snapshots__/change_url_modal.test.jsx.snap
@@ -35,7 +35,7 @@ exports[`components/ChangeURLModal should match snapshot, modal not showing 1`]
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="changeUrlModalLabel"
  >
  Change URL
@@ -178,7 +178,7 @@ exports[`components/ChangeURLModal should match snapshot, modal showing 1`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="changeUrlModalLabel"
  >
  Change URL
@@ -321,7 +321,7 @@ exports[`components/ChangeURLModal should match snapshot, on currentURL 1`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="changeUrlModalLabel"
  >
  Change URL
@@ -473,7 +473,7 @@ exports[`components/ChangeURLModal should match snapshot, on urlError 1`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="changeUrlModalLabel"
  >
  Change URL
@@ -625,7 +625,7 @@ exports[`components/ChangeURLModal should match snapshot, with a input 1`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="changeUrlModalLabel"
  >
  Change URL

diff --git a/components/change_url_modal/change_url_modal.jsx b/components/change_url_modal/change_url_modal.jsx
@@ -184,7 +184,12 @@ export default class ChangeURLModal extends React.PureComponent {
  aria-labelledby='changeUrlModalLabel'
  >
  <Modal.Header closeButton={true}>
- <Modal.Title id='changeUrlModalLabel'>{this.props.title}</Modal.Title>
+ <Modal.Title
+ componentClass='h1'
+ id='changeUrlModalLabel'
+ >
+ {this.props.title}
+ </Modal.Title>
  </Modal.Header>
  <form
  role='form'

diff --git a/components/channel_info_modal/__snapshots__/channel_info_modal.test.jsx.snap b/components/channel_info_modal/__snapshots__/channel_info_modal.test.jsx.snap
@@ -37,7 +37,7 @@ exports[`components/ChannelInfoModal should match snapshot 1`] = `
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="channelInfoModalLabel"
  >
  <FormattedMessage
@@ -126,7 +126,7 @@ exports[`components/ChannelInfoModal should match snapshot with channel props 1`
  >
  <ModalTitle
  bsClass="modal-title"
- componentClass="h4"
+ componentClass="h1"
  id="channelInfoModalLabel"
  >
  <FormattedMessage

diff --git a/components/channel_info_modal/channel_info_modal.jsx b/components/channel_info_modal/channel_info_modal.jsx
@@ -143,7 +143,10 @@ export default class ChannelInfoModal extends React.PureComponent {
  aria-labelledby='channelInfoModalLabel'
  >
  <Modal.Header closeButton={true}>
- <Modal.Title id='channelInfoModalLabel'>
+ <Modal.Title
+ componentClass='h1'
+ id='channelInfoModalLabel'
+ >
  <FormattedMessage
  id='channel_info.about'
  defaultMessage='About'