MM-15709 certain aspect ratio of images cause pop on firefox (matterm…

…ost#2826) * MM-155703 certain aspect ratio of images cause pop on firefox * Svg's need max dimention styles with px suffix * remove string convertion and keep maxHeight and maxWidth as numbers
Revanth47 · May 22, 2019 · 0dab1a5 · 0dab1a5
1 parent 6523f32
commit 0dab1a5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/components/__snapshots__/size_aware_image.test.jsx.snap b/components/__snapshots__/size_aware_image.test.jsx.snap
@@ -22,8 +22,8 @@ exports[`components/SizeAwareImage should render a placeholder and has loader wh
  <svg
  style={
  Object {
- "maxHeight": "200",
- "maxWidth": "300",
+ "maxHeight": 200,
+ "maxWidth": 300,
  "verticalAlign": "middle",
  }
  }

diff --git a/components/size_aware_image.jsx b/components/size_aware_image.jsx
@@ -120,7 +120,7 @@ export default class SizeAwareImage extends React.PureComponent {
  <svg
  xmlns='https://www.w3.org/2000/svg'
  viewBox={`0 0 ${dimensions.width} ${dimensions.height}`}
- style={{verticalAlign: 'middle', maxHeight: `${dimensions.height}`, maxWidth: `${dimensions.width}`}}
+ style={{verticalAlign: 'middle', maxHeight: dimensions.height, maxWidth: dimensions.width}}
  />
  </div>
  );