Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d3.selectAll not restricted to current cell #7

Closed
JobJob opened this issue May 19, 2017 · 4 comments
Closed

d3.selectAll not restricted to current cell #7

JobJob opened this issue May 19, 2017 · 4 comments

Comments

@JobJob
Copy link
Contributor

JobJob commented May 19, 2017

Hi,

Just wanted to say thanks for this package and let you know that I made a minimal port of some of this project to Julia here: https://github.com/JobJob/D3Magic.jl

One other thing, when I was looking at the code it seemed your regex won't match "d3.selectAll(..." - or maybe I just missed something.

Cheers

@ResidentMario
Copy link
Owner

That's great to see!

A quick check on RegExr shows that you seem to be right about that. It's been a while since I wrote this but I'm pretty sure it works with selectAll, right? Would be a pretty serious bug if not. If you could check on that, that would be helpful.

@JobJob
Copy link
Contributor Author

JobJob commented May 20, 2017

Yep, seems to be a problem. Try this one on a saved, or probably better, new notebook

%%d3

<script>
d3.selectAll("div").remove()
</script>

@JobJob JobJob changed the title Ported to Julia - Thanks d3.selectAll not restricted to current cell May 24, 2017
ResidentMario added a commit that referenced this issue Jul 2, 2017
@ResidentMario
Copy link
Owner

Your patch with the fix is now live in 0.2.7. Sorry it took so long; I totally forgot about this, and only caught it when I was doing a once over on things yesterday.

@JobJob
Copy link
Contributor Author

JobJob commented Jul 2, 2017

Ha - no probs - I also forgot about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants