Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small refactor for acls, extract user creation/get into function #578

Merged
merged 4 commits into from
Mar 15, 2023

Conversation

sjpotter
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Merging #578 (67e75f8) into master (508b61b) will increase coverage by 0.18%.
The diff coverage is 94.05%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   58.06%   58.24%   +0.18%     
==========================================
  Files          42       42              
  Lines       14719    14679      -40     
  Branches     1735     1731       -4     
==========================================
+ Hits         8546     8550       +4     
+ Misses       6173     6129      -44     
Impacted Files Coverage Δ
src/redisraft.h 100.00% <ø> (ø)
src/redisraft.c 73.81% <90.00%> (+0.39%) ⬆️
src/config.c 43.28% <91.11%> (+1.59%) ⬆️
src/snapshot.c 84.11% <95.23%> (-0.04%) ⬇️
src/migrate.c 77.14% <100.00%> (ø)
src/raft.c 88.83% <100.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@fadidahanna fadidahanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to fix 2 small style issues (see CI failure)

@fadidahanna fadidahanna merged commit 194cb2a into RedisLabs:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants