Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase response-timeout for big snapshot tests #577

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

tezc
Copy link
Collaborator

@tezc tezc commented Jan 24, 2023

https://github.com/RedisLabs/redisraft/actions/runs/3991700932/jobs/6846775748

Ran this test with trace level logs, looks like due to extreme slow-down on MacOS instance, followers send snapshot message responses after a second. Default response-timeout is 1 second. So, leader node marks the request failed and retries. It takes quite a time to finish snapshot delivery, sometimes test fails due to wait_for_unanimity() timeout which is 20 seconds.

For the two tests that use big snapshots, this PR increases response-timeout to 5 seconds.

@codecov-commenter
Copy link

Codecov Report

Merging #577 (83af773) into master (49b292c) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   58.08%   58.04%   -0.05%     
==========================================
  Files          42       42              
  Lines       14717    14717              
  Branches     1734     1734              
==========================================
- Hits         8548     8542       -6     
- Misses       6169     6175       +6     
Impacted Files Coverage Δ
src/join.c 73.58% <0.00%> (-7.55%) ⬇️
src/common.c 76.92% <0.00%> (-2.31%) ⬇️
deps/raft/src/raft_server.c 80.79% <0.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tezc tezc merged commit 14e0ac4 into RedisLabs:master Jan 31, 2023
@tezc tezc deleted the debug-log branch January 31, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants