SQLite WriteBehind insert into fix #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 6920723 into 0d1b88c - view on LGTM.com new alerts:
|
|
This pull request fixes 1 alert when merging 364374d into 0d1b88c - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 428ff06 into 0d1b88c - view on LGTM.com fixed alerts:
|
MeirShpilraien
approved these changes
Dec 8, 2021
|
This pull request fixes 1 alert when merging cfdf2e1 into 0d1b88c - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the UPSERT goal of the MySQL PR, for SQLite. Note, you can't use REPLACE INFO with SQLITE for our use case, as it has the unintended side-effect on tables with an auto-incrementing primary key, of deleting the row and creating a new row.
As a result we use the INSERT INTO with CONFLICT DO UPDATE SET, accordingly.