update rhevm api uri to support 4.0 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -95,6 +95,10 @@ def __init__(self, hostname, username, password, **kwargs): | |||
| else: | |||
| url = 'https://%s/api' % hostname | |||
|
|
|||
| if 'version' in kwargs: | |||
There was a problem hiding this comment.
There is more to it than this I think, the RHEVM API has moved, we will need to investigate this. Does the old client API support 4.0? We froze the requirement for ovirtsdk to get around it.
There was a problem hiding this comment.
It's probably cleaner to do this
url_component = 'ovirt-engine/api' if float(kwargs['version']) >= 4.0 else 'api'
if 'port' in kwargs:
url = 'https://{}:{}/{}'.format(hostname, kwargs['port'], url_component)
else:
url = 'https://{}/{}'.format(hostname, url_component)26d7096
to
3a9cce1
Compare
* appended 'ovirt-engine' to rhevm api uri.
|
Lint report for commit dcff0e5: Everything seems all right from lint perspective 😄 . Commit inspection report: CFME QE Bot |
|
PR #60 adressed this and it only requires an additional entry in the yaml (api_endpoint) :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the rhevm api uri needs to include 'ovirt-engine' for version 4.0. so the uri would look like: https://rhevmip/ovirt-engine/api before it used to be https://rhevmip/api