Add support for collecting deletable OCPs from AWS #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrapanapi/systems/ec2.py
Outdated
| @@ -531,7 +553,7 @@ def id(self) -> str: | |||
| This part is used as id in aws cli. | |||
| """ | |||
| if self.arn: | |||
| return self.arn.split(":")[-1] | |||
| return self.arn.split(":")[-1].split("/")[-1] | |||
There was a problem hiding this comment.
looking at the docs here https://docs.aws.amazon.com/quicksight/latest/APIReference/qs-arn-format.html it could be three formats
arn:partition:service:region:account-id:resource-id
arn:partition:service:region:account-id:resource-type/resource-id
arn:partition:service:region:account-id:resource-type:resource-id
it will fail for others ? I think you need to handle that ?
There was a problem hiding this comment.
Resolved in latest commit
omkarkhatavkar
suggested changes
Jun 3, 2024
|
/verified |
jyejare
approved these changes
Jun 12, 2024
|
/verified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
list_resourcesflow to catch and log client error when using ResourceExplorer through an unauthorized client