Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 185] Allow adding labels to issues via a file in the $SHARED_DIR #203

Merged
merged 15 commits into from
Jul 2, 2024

Conversation

calebevans
Copy link
Collaborator

@calebevans calebevans commented Jun 28, 2024

  • Adds functionality to include any labels listen in the $SHARED_DIR/firewatch-additional-labels file in OpenShift CI.
    • Labels should be separated by a new line.
  • Add tests for new functionality.
  • Updates test job, old one seems to be out of date and causing tests to fail.

Example:

  1. Add a label to the file in OpenShift CI: echo "some-label" >> $SHARED_DIR/firewatch-additional-labels.
  2. Observe that any new ticket created will include the some-label label.

Closes #185

@calebevans calebevans self-assigned this Jun 28, 2024
@calebevans calebevans requested a review from amp-rh June 28, 2024 21:40
@redhat-qe-bot1
Copy link

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
Supported /retest check runs
  • This repository does not support retest actions
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@calebevans
Copy link
Collaborator Author

/verified

@dfrazzette
Copy link
Collaborator

/lgtm

@dfrazzette
Copy link
Collaborator

@calebevans - Is it worth updating the Approvers in the repo's OWNERS list? The can-be-merged
check is failing with:
Missing lgtm/approved from approvers ['calebevans', 'btjd', 'ascerra', 'myakove', 'rnetser']

src/report/report.py Outdated Show resolved Hide resolved
@calebevans
Copy link
Collaborator Author

/verified

@oharan2
Copy link
Collaborator

oharan2 commented Jul 1, 2024

/lgtm

@btjd
Copy link

btjd commented Jul 1, 2024

/lgtm

@calebevans
Copy link
Collaborator Author

/verified

@btjd
Copy link

btjd commented Jul 2, 2024

/lgtm

@calebevans calebevans merged commit 0a61321 into RedHatQE:main Jul 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Allow adding labels to issues via a file in the $SHARED_DIR
10 participants