Add redirectURL params in github/login route #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const router = express.Router(); | ||
| const auth = require("../controllers/auth"); | ||
|
|
||
| router.get("/github/login", passport.authenticate("github", { scope: ["user:email"] })); | ||
| router.get("/github/login", auth.githubAuthLogin); |
Check failure
Code scanning / CodeQL
Missing rate limiting
|
|
||
| router.get("/github/callback", auth.githubAuth); | ||
| router.get("/github/callback", auth.githubAuthCallback); |
Check failure
Code scanning / CodeQL
Missing rate limiting
bce1502
to
35d168e
Compare
RitikJaiswal75
previously approved these changes
Jun 30, 2023
sahsisunny
previously approved these changes
Jun 30, 2023
shubham-y
suggested changes
Jul 2, 2023
cc91c6e
shubham-y
approved these changes
Jul 2, 2023
RitikJaiswal75
approved these changes
Jul 26, 2023
ankushdharkar
pushed a commit
that referenced
this pull request
Jul 27, 2023
* Added get route for fetching user device info * Added validator for query params * Fixed integration test * Removed console log * Updated integration test * Added validator test * Refactor controller functions to use service layer for retrieving user data (/users/userId/:userId) route (/users/self) route (#1249) * removal of sensitive info(phone,email,tokens,chaincode) on /users route * update in removal of sensitive info(phone,email,tokens,chaincode) on /users route * Update dataAccessLayer.js * updated query id and qualifiers params in /users in removal of sensitive info(phone,email,tokens,chaincode) on /users route * updated dataAccessLayer for lint issues * Update users.js * updated delete statement to hasOwnProperty * updated default arguments to function removeSensitiveInfo * made updates in the dataAccessLayer * Update users.js * typo fixes * Added unit tests * updated to using in operator * updated to query as argument in place of req * updates to /user/userId * added code changes for /self route * remove extra lines * Update users.js * removed commented lines * lint error fix * Update users.js --------- Co-authored-by: Sen, Sriza <[email protected]> * Stop collecting github access token and remove it from existing user's data (#1227) * wrote scripts and tests * forgot to add this file * fixing test errors * implemented batch instead of promise.all to send update request to firestore * fixed test and resolved comments * fixed tests * forgot to fix this * forgot to fix this * preventing object sink * preventing object sink * fixing function call object sink warning * ignore object sink * resolved comments by randhir * resolved comments * fixing tests * refactor all occurrences of fetchUser,fetchUsers (#1293) * refactor occurrences of fetchUser,fetchUsers * added unit tests * added lint fixes * refactor remaining fetchUser in users controller * added lint fix and test errors fix * added lint fix and test errors fix * added lint fix * refactor username * refactor for getDiscordUsers * added refactor for members model queries * added lint fix * remove extra spaces * added suggested change * handled edge case * added lint fix * FEATURE: change `in_discord` role based on condition (#1324) * FEATURE: true/false in_discord role based on recieve data from RDS and Discord * TEST: fix failing test * FEATURE: add userUpdatedWithInDiscordFalse in response * REFACTOR: syncExternalAccountData condition * REFACTOR: syncExternalAccountData function * FIX: order of arguments in addOrUpdate function call * Update controllers/external-accounts.js Co-authored-by: Randhir Kumar Singh <[email protected]> --------- Co-authored-by: Randhir Kumar Singh <[email protected]> * Add redirectURL params in github/login route (#937) * feat: add redirectURL params in github/loign route * Fix tests * chore:fix-test * chore: add new test coverage * fix endswith edgecase --------- Co-authored-by: Satyam Negi <[email protected]> Co-authored-by: Sriza Sen <[email protected]> Co-authored-by: Sen, Sriza <[email protected]> Co-authored-by: Fakhruddin KW <[email protected]> Co-authored-by: Randhir Kumar Singh <[email protected]> Co-authored-by: Prakash Choudhary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/auth/github/login?redirectURL="any-realdevsquad-website"Adds
redirectURLquery params, to redirect to the specified URLCloses: #1213