Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made a in memory cache module and added it to /tasks endpoint #713

Merged
merged 4 commits into from
Sep 25, 2022
Merged

Made a in memory cache module and added it to /tasks endpoint #713

merged 4 commits into from
Sep 25, 2022

Conversation

yesyash
Copy link
Contributor

@yesyash yesyash commented Sep 20, 2022 •
edited
Loading

Issue Ticket #729

Description

  • Created a cache module to get and store API responses from the cache pool for a controller.
  • Cached responses from /tasks endpoint using the cache module.

Working

cache module flow - pr 1

@yesyash yesyash mentioned this pull request Sep 21, 2022
Open
samarpan1738
samarpan1738 reviewed Sep 21, 2022
View reviewed changes
utils/cache.js Outdated Show resolved Hide resolved
samarpan1738
samarpan1738 reviewed Sep 21, 2022
View reviewed changes
utils/cache.js Outdated Show resolved Hide resolved
samarpan1738
samarpan1738 reviewed Sep 21, 2022
View reviewed changes
utils/cache.js Outdated Show resolved Hide resolved
samarpan1738
samarpan1738 reviewed Sep 21, 2022
View reviewed changes
utils/cache.js Outdated Show resolved Hide resolved
rupal-2505
rupal-2505 reviewed Sep 22, 2022
View reviewed changes
Copy link

@rupal-2505 rupal-2505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maheima
Maheima approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@Maheima Maheima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ivinayakg
ivinayakg reviewed Sep 24, 2022
View reviewed changes
Copy link
Contributor

@ivinayakg ivinayakg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks fantastic, there are pieces that I am not 100% sure I will read about that will come back.
I know you already know this but just a reminder, add tests before merging 😊

@yesyash
Copy link
Contributor Author

yesyash commented Sep 24, 2022

the code looks fantastic, there are pieces that I am not 100% sure I will read about that will come back. I know you already know this but just a reminder, add tests before merging 😊

Working on writing tests will be out soon. Thank you for mentioning it.

ankurnarkhede
ankurnarkhede suggested changes Sep 25, 2022
View reviewed changes
utils/cache.js Show resolved Hide resolved
utils/cache.js Show resolved Hide resolved
ankurnarkhede
ankurnarkhede approved these changes Sep 25, 2022
View reviewed changes
utils/cache.js Show resolved Hide resolved
utils/cache.js Show resolved Hide resolved
@ankushdharkar ankushdharkar merged commit 74cb191 into Real-Dev-Squad:develop Sep 25, 2022
@yesyash yesyash mentioned this pull request Oct 4, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarpan1738 samarpan1738 samarpan1738 left review comments

@ivinayakg ivinayakg ivinayakg left review comments

@rupal-2505 rupal-2505 rupal-2505 left review comments

@ankurnarkhede ankurnarkhede ankurnarkhede approved these changes

@Maheima Maheima Maheima approved these changes

@alishvagadiya alishvagadiya Awaiting requested review from alishvagadiya

@SBagaria2710 SBagaria2710 Awaiting requested review from SBagaria2710

@vinayak-trivedi vinayak-trivedi Awaiting requested review from vinayak-trivedi

Assignees

@yesyash yesyash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yesyash @ankurnarkhede @samarpan1738 @Maheima @ivinayakg @rupal-2505 @ankushdharkar