Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accepting coordinates with body for croping image in cloudinary #515

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

prakashchoudhary07
Copy link
Contributor

No description provided.

@@ -26,7 +26,7 @@ const multerErrorHandling = (err, req, res, next) => {
if (err.code === 'LIMIT_FILE_SIZE') {
res.boom.entityTooLarge(errorMessage.FILE_TOO_LARGE(profileFileSize / MB_1))
} else if (err.code === 'LIMIT_UNEXPECTED_FILE') {
res.boom.badImplementation(errorMessage.ONLY_ONE_FILE_ALLOWED)
res.boom.badData(errorMessage.ONLY_ONE_FILE_ALLOWED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to also check for badImplementation?

Copy link
Contributor

@harshith-venkatesh harshith-venkatesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest all looks good.
NIT: if badImplementation is included in badData error else you can assign it as new PR too I believe

@sumitd94 sumitd94 merged commit ce29e28 into develop Feb 2, 2022
@sumitd94 sumitd94 deleted the feature/cloudinary-crop-with-coordinates branch February 2, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants