Removed checkIsVerifiedDiscord for discord-actions/nicknames/sync API #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavangbhat
changed the title
skv93-coder
approved these changes
Mar 27, 2024
iamitprakash
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 18-03-2024
Developer Name: Pavan Bhat
Issue Ticket Number
#1989
Description
Removed Middleware for Reference:
This route
discord-actions/nicknames/syncis behind a middleware accessingreq.userDatawhich would only be available if the call is made through website-dashboard. As we move these routes to a cronjob, we need to remove this check. Have verifiedreq.userDatais not being used for this route's controller and is safe to removeDocumentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes