Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables task status verified and merged #1937

Merged
merged 10 commits into from
Mar 22, 2024
Merged

Conversation

skv93-coder
Copy link
Contributor

@skv93-coder skv93-coder commented Mar 3, 2024

Date: Mar 5 2024

Developer Name: @skv93-coder


Issue Ticket Number

Real-Dev-Squad/website-my#554

Description

This PR will enable the user to update the task status to Merged and Verified and prevent the user from updating the task status when task status is Done.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screencast.from.04-03-24.09.49.03.PM.IST.webm
Screenshot 1

Test Coverage

Unit test stats
Screenshot from 2024-03-05 06-43-35
Integration test stats
Screenshot from 2024-03-05 06-53-15

Screenshot 1

Additional Notes

Removed test cases are for behaviour which we no longer need

@skv93-coder skv93-coder marked this pull request as ready for review March 6, 2024 15:41
Copy link
Member

@Achintya-Chatterjee Achintya-Chatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skv93-coder tests are failing, Kindly look into that. Rest all are looking good

@skv93-coder skv93-coder changed the title Remove condition for updating task for verified task status and perce… Enables task status verified and merged Mar 18, 2024
@skv93-coder skv93-coder mentioned this pull request Mar 18, 2024
10 tasks
controllers/tasks.js Show resolved Hide resolved
controllers/tasks.js Show resolved Hide resolved
@iamitprakash iamitprakash merged commit d87cf8d into develop Mar 22, 2024
3 checks passed
@iamitprakash iamitprakash deleted the feature/task-status branch March 22, 2024 07:22
@skv93-coder skv93-coder mentioned this pull request Mar 24, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants