Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to pass down the header to bot #1848

Merged
merged 14 commits into from
Jan 21, 2024

Conversation

skv93-coder
Copy link
Contributor

@skv93-coder skv93-coder commented Jan 15, 2024

Date: 16-Jan-24

Developer Name: @skv93-coder


Issue Ticket Number

Real-Dev-Squad/discord-slash-commands#167

Description

This issue enables the passing of username and id to the Cloudflare bot.

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

screen-capture.3.webm

Test Coverage

Screenshot from 2024-01-16 23-20-18
Screenshot from 2024-01-16 23-24-58

Screenshot from 2024-01-19 23-12-12
Screenshot from 2024-01-19 23-14-01

Additional Notes

@skv93-coder skv93-coder marked this pull request as ready for review January 17, 2024 12:33
controllers/discordactions.js Outdated Show resolved Hide resolved
controllers/discordactions.js Show resolved Hide resolved
models/discordactions.js Show resolved Hide resolved
test/integration/discordactions.test.js Outdated Show resolved Hide resolved
test/integration/discordactions.test.js Show resolved Hide resolved
test/integration/discordactions.test.js Outdated Show resolved Hide resolved
test/integration/discordactions.test.js Show resolved Hide resolved
test/unit/utils/genrateCloudFlareHeaders.test.js Outdated Show resolved Hide resolved
@satyam73
Copy link
Member

Please add the test coverage for the files that you have modified

controllers/discordactions.js Show resolved Hide resolved
models/discordactions.js Show resolved Hide resolved
@skv93-coder
Copy link
Contributor Author

Please add the test coverage for the files that you have modified

Added the stats

@satyam73
Copy link
Member

Please fix typos

@iamitprakash iamitprakash merged commit efbe329 into develop Jan 21, 2024
3 checks passed
@iamitprakash iamitprakash deleted the feature/group/audit-logs branch January 21, 2024 16:59
@skv93-coder skv93-coder mentioned this pull request Jan 21, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants