Refactor : Moved code to models

controllers/users.js

@@ -1,4 +1,3 @@
-const firestore = require("../utils/firestore");
 const chaincodeQuery = require("../models/chaincodes");
 const userQuery = require("../models/users");
 const profileDiffsQuery = require("../models/profileDiffs");
@@ -16,7 +15,7 @@ const { getPaginationLink, getUsernamesFromPRs, getRoleToUpdate } = require("../
 const { setInDiscordFalseScript, setUserDiscordNickname } = require("../services/discordService");
 const { generateDiscordProfileImageUrl } = require("../utils/discord-actions");
 const { addRoleToUser, getDiscordMembers } = require("../services/discordService");
-const { fetchAllUsers } = require("../models/users");
+const { fetchAllUsers, addGithubUserId } = require("../models/users");
 const { getOverdueTasks } = require("../models/tasks");
 const { getQualifiers } = require("../utils/helper");
 const { parseSearchQuery } = require("../utils/users");
@@ -857,72 +856,21 @@ async function usersPatchHandler(req, res) {
  return res.boom.badImplementation(INTERNAL_SERVER_ERROR);
  }
 }
-const addGithubId = async (req, res) => {
+const migrations = async (req, res) => {
  const { action } = req.query;
  if (action !== "adds-github-id") {
  return res.status(400).json({
  message: "Invalid action type",
  });
  }
- const usersNotFound = [];
- let countUserFound = 0;
- let countUserNotFound = 0;
+
  try {
- const requestOptions = {
- method: "GET",
- headers: {
- "Content-Type": "application/json",
- Authorization:
- "Basic " + btoa(`${config.get("githubOauth.clientId")}:${config.get("githubOauth.clientSecret")}`),
- },
- };
- const usersSnapshot = await firestore.collection("users").get();
- const totalUsers = usersSnapshot.docs.length;
- const batchCount = Math.ceil(totalUsers / 500);
- // Create batch write operations for each batch of documents
- for (let i = 0; i < batchCount; i++) {
- const batchWrite = firestore.batch();
- const batchWrites = [];
- for (const userDoc of usersSnapshot.docs.slice(i * 500, (i + 1) * 500)) {
- const githubUsername = userDoc.data().github_id;
- const username = userDoc.data().username;
- const userId = userDoc.id;
- batchWrite.update(userDoc.ref, { github_user_id: null });
-
- const getUserDetails = fetch(`https://api.github.com/users/${githubUsername}`, requestOptions)
- .then((response) => {
- if (!response.ok) {
- throw new Error("Network response was not ok");
- }
- return response.json();
- })
- .then((data) => {
- const githubUserId = data.id;
- batchWrite.update(userDoc.ref, { github_user_id: `${githubUserId}` });
- countUserFound++;
- })
- .catch((error) => {
- countUserNotFound++;
- const invalidUsers = { userId, username, githubUsername };
- usersNotFound.push(invalidUsers);
- logger.error("An error occurred at fetch:", error);
- });
- batchWrites.push(getUserDetails);
- }
- await Promise.all(batchWrites);
- await batchWrite.commit();
- }
+ const result = await addGithubUserId();
  return res.status(200).json({
  message: "Result of migration",
- data: {
- totalUsers: totalUsers,
- usersUpdated: countUserFound,
- usersNotUpdated: countUserNotFound,
- invalidUsersDetails: usersNotFound,
- },
+ data: result,
  });
  } catch (error) {
- logger.error(`Error while Updating all users: ${error}`);
  return res.boom.badImplementation(INTERNAL_SERVER_ERROR);
  }
 };
@@ -956,5 +904,5 @@ module.exports = {
  updateDiscordUserNickname,
  archiveUserIfNotInDiscord,
  usersPatchHandler,
- addGithubId,
+ migrations,
 };

models/users.js

@@ -868,6 +868,68 @@ const getNonNickNameSyncedUsers = async () => {
  throw err;
  }
 };
+const addGithubUserId = async () => {
+ try {
+ const usersNotFound = [];
+ let countUserFound = 0;
+ let countUserNotFound = 0;
+
+ const requestOptions = {
+ method: "GET",
+ headers: {
+ "Content-Type": "application/json",
+ Authorization:
+ "Basic " + btoa(`${config.get("githubOauth.clientId")}:${config.get("githubOauth.clientSecret")}`),
+ },
+ };
+ const usersSnapshot = await firestore.collection("users").get();
+ const totalUsers = usersSnapshot.docs.length;
+ const batchCount = Math.ceil(totalUsers / 500);
+ // Create batch write operations for each batch of documents
+ for (let i = 0; i < batchCount; i++) {
+ const batchWrite = firestore.batch();
+ const batchWrites = [];
+ for (const userDoc of usersSnapshot.docs.slice(i * 500, (i + 1) * 500)) {
+ if (userDoc.data().github_user_id) continue;
+ const githubUsername = userDoc.data().github_id;
+ const username = userDoc.data().username;
+ const userId = userDoc.id;
+ batchWrite.update(userDoc.ref, { github_user_id: null });
+
+ const getUserDetails = fetch(`https://api.github.com/users/${githubUsername}`, requestOptions)
+ .then((response) => {
+ if (!response.ok) {
+ throw new Error("Network response was not ok");
+ }
+ return response.json();
+ })
+ .then((data) => {
+ const githubUserId = data.id;
+ batchWrite.update(userDoc.ref, { github_user_id: `${githubUserId}` });
+ countUserFound++;
+ })
+ .catch((error) => {
+ countUserNotFound++;
+ const invalidUsers = { userId, username, githubUsername };
+ usersNotFound.push(invalidUsers);
+ logger.error("An error occurred at fetch:", error);
+ });
+ batchWrites.push(getUserDetails);
+ }
+ await Promise.all(batchWrites);
+ await batchWrite.commit();
+ }
+ return {
+ totalUsers: totalUsers,
+ usersUpdated: countUserFound,
+ usersNotUpdated: countUserNotFound,
+ invalidUsersDetails: usersNotFound,
+ };
+ } catch (error) {
+ logger.error(`Error while Updating all users: ${error}`);
+ throw Error(error);
+ }
+};
 
 module.exports = {
  addOrUpdate,
@@ -898,4 +960,5 @@ module.exports = {
  fetchUsersListForMultipleValues,
  fetchUserForKeyValue,
  getNonNickNameSyncedUsers,
+ addGithubUserId,
 };

routes/users.js

@@ -62,5 +62,5 @@
 router.patch("/:userId", authenticate, authorizeRoles([SUPERUSER]), users.updateUser);
 router.get("/suggestedUsers/:skillId", authenticate, authorizeRoles([SUPERUSER]), users.getSuggestedUsers);
 // WARNING!! - One time Script/Route to do migration
-router.post("/migrations", authenticate, authorizeRoles([SUPERUSER]), users.addGithubId);
+router.post("/migrations", authenticate, authorizeRoles([SUPERUSER]), users.migrations);
 module.exports = router;