-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds pagination to extension request list #1419
Conversation
router.get("/", authenticate, authorizeRoles([SUPERUSER, APPOWNER]), extensionRequests.fetchExtensionRequests); | ||
router.get( | ||
"/", | ||
authenticate, |
Check failure
Code scanning / CodeQL
Missing rate limiting High
authorization
This route handler performs
authorization
This route handler performs
authorization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey Ajeyakrishna, In case we want to use multiple params we must use query params like
q=status:assigned+available
we wont be using &
(Moving to RDS's own query language)
@RitikJaiswal75 I need a more clarity on this. |
Please update the API contracts for it |
…ackend into fix/extension-requests
Ive raised a PR for the same: Real-Dev-Squad/website-api-contracts#154 |
Issue: Real-Dev-Squad/website-dashboard#430
What is the change?
?q=status:APPROVED
. This PR allows us to filter the data based on multiple values eg:?q=status:APPROVED+PENDING
?size=10
.created time
.eg:?order=asc
Note to Reviewers:
?dev=true
query param.API contract:
Real-Dev-Squad/website-api-contracts#154
Test stats
Before :
![Screenshot 2023-08-15 at 8 15 17 PM](https://private-user-images.githubusercontent.com/98796547/260766170-e30e6fd0-0ee6-4002-8a84-2de1e41f0862.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM1ODY2MjYsIm5iZiI6MTcyMzU4NjMyNiwicGF0aCI6Ii85ODc5NjU0Ny8yNjA3NjYxNzAtZTMwZTZmZDAtMGVlNi00MDAyLThhODQtMmRlMWU0MWYwODYyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODEzVDIxNTg0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY0ZjQzNjQzYWY3NDczN2M2MTM1ODAyNjU4M2Q1NmY2NDA5NDQ2ZTczYzA5MzRjNTA5MmRiNTQyZDhkZTQ2YjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.nPBjM-iJtx2ad0gH095vouFIv9QW2Kgzcw9RvFaOSpI)
After:
![Screenshot 2023-08-15 at 8 16 11 PM](https://private-user-images.githubusercontent.com/98796547/260766223-0f38dba5-af47-4a86-bd03-1ce1636f519e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM1ODY2MjYsIm5iZiI6MTcyMzU4NjMyNiwicGF0aCI6Ii85ODc5NjU0Ny8yNjA3NjYyMjMtMGYzOGRiYTUtYWY0Ny00YTg2LWJkMDMtMWNlMTYzNmY1MTllLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODEzVDIxNTg0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNlNTg0M2IzMjIyMjM1MDdiYzVlMGUyOTVmOWFhZTgzZDYzMTI3OGJlMzQ0MTFlZjcwYWJmNGI5MDczNTgzMDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.b3bBxXNZJ1db0D1H4BbJYoF57ReRBKjKoOGz3QuJUoE)
*Dev Tested?
Screenshot:
Indexes :
The following indexes needs to be created with these change:
![Screenshot 2023-08-15 at 9 32 52 PM](https://private-user-images.githubusercontent.com/98796547/260769249-fd80c380-2e01-488a-9de2-59b9313367d6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM1ODY2MjYsIm5iZiI6MTcyMzU4NjMyNiwicGF0aCI6Ii85ODc5NjU0Ny8yNjA3NjkyNDktZmQ4MGMzODAtMmUwMS00ODhhLTlkZTItNTliOTMxMzM2N2Q2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODEzVDIxNTg0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRkMjQ2ZDY2NDdiZWJlNGZlODBkMDIxM2FlYjc0NjNkMGI5Zjc0MDYzODVjMjQ2ODQyYWIxNzc0OGZlZTEyYjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.amY2S0uRbroSCPMBI-Xw_RoXJSyr3OybPqrnNZ4fMZk)