Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added middleware for subscribe API #1102

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Added middleware for subscribe API #1102

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ed530e4
added middleware for subscribe API
arpit01923 May 20, 2023
a488041
updated validation
arpit01923 May 21, 2023
d4f6f2e
Merge branch 'Real-Dev-Squad:develop' into develop
arpit01923 Jun 5, 2023
e4f55f0
removed uuid from subscribeToChallenge validator
arpit01923 Jun 5, 2023
b2ed956
Merge branch 'Real-Dev-Squad:develop' into develop
arpit01923 Jun 8, 2023
1ccb3f7
issue fixes
arpit01923 Jun 8, 2023
097760d
added test code coverage
arpit01923 Jun 12, 2023
5be5e50
Merge branch 'Real-Dev-Squad:develop' into develop
arpit01923 Jun 19, 2023
316c1ce
updated error message of /challenges/subscribe
arpit01923 Jun 19, 2023
9e36ef4
Merge branch 'Real-Dev-Squad:develop' into develop
arpit01923 Jul 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions middlewares/validators/challenges.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,22 @@ const createChallenge = async (req, res, next) => {
}
};

const subscribeToChallenge = async (req, res, next) => {
const schema = joi.object().strict().keys({
userId: joi.string().required(),
challengeId: joi.string().required(),
khushi818 marked this conversation as resolved.
Show resolved Hide resolved
});

try {
await schema.validateAsync(req.body);
next();
} catch (error) {
logger.error(`Error validating subscribeToChallenge payload : ${error}`);
res.boom.badRequest(error.details[0].message);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @arpit01923, sending the exact error message to the end user might be harmful and can expose critical information on the backend Making us prone to external threats.

We already have a response saved in constants file which can be used here to send back to the end user.

Copy link
Author

@arpit01923 arpit01923 Jun 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error message changed

}
};

module.exports = {
createChallenge,
subscribeToChallenge
};
4 changes: 2 additions & 2 deletions routes/challenges.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ const express = require("express");
const router = express.Router();
const authenticate = require("../middlewares/authenticate");
const challenges = require("../controllers/challenge");
const { createChallenge } = require("../middlewares/validators/challenges");
const { createChallenge, subscribeToChallenge } = require("../middlewares/validators/challenges");

router.get("/", authenticate, challenges.fetchChallenges);
router.post("/", authenticate, createChallenge, challenges.createChallenge);
router.post("/subscribe", authenticate, challenges.subscribeToChallenge);
router.post("/subscribe", authenticate, subscribeToChallenge, challenges.subscribeToChallenge);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
This route handler performs
authorization
Loading
, but is not rate-limited.
This route handler performs
authorization
Loading
, but is not rate-limited.

module.exports = router;