GitHub Duplication Fix #1072
Closed
GitHub Duplication Fix #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close [RFC] GitHub Duplication #957
closed PR GitHub duplication Fixed and Migration #1044 - visit this to check old conversations
Added a new field (github_user_id) to the Firestore database.
RFC DOCUMENT
Tests Added:
UNIT TESTS
✔ should add the github_user_id to the user collection
✔ should update the github_user_id in the user collection (40ms)
✔ should be a string
✔ should have a maximum length of 8 characters
✔ should be stored correctly in the database
INTEGRATION TESTS
✔ Should return 401 when user is unauthorize
✔ Should update the user
✔ Should return unauthorized error when not logged in