filter members option in user API #1001
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(response.body.links).to.have.property("prev"); | ||
|
|
||
| expect(response.body.users[0].roles.member).to.be.equal(true); | ||
| expect(response.body.users[0].roles.archived).to.be.equal(false); |
There was a problem hiding this comment.
can we also test the length of the response returned?
There was a problem hiding this comment.
I think we do not need to test it
prakashchoudhary07
requested changes
Apr 8, 2023
Comment on lines
+133
to
+151
| if (query.member === "true") { | ||
| const membersArray = []; | ||
| const snapshot = await userModel.where("roles.member", "==", true).where("roles.archived", "==", false).get(); | ||
| if (!snapshot.empty) { | ||
| snapshot.forEach((doc) => { | ||
| membersArray.push({ | ||
| id: doc.id, | ||
| ...doc.data(), | ||
| phone: undefined, | ||
| email: undefined, | ||
| tokens: undefined, | ||
| chaincode: undefined, | ||
| }); | ||
| }); | ||
| } | ||
| return { | ||
| allUsers: membersArray, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Please handle this in the bottom part, where users are being fetched. We are just repeating code here.
There is no pagination here, even though user API has pagination.
And instead of having a key where member=true, let's generic field like a filter or role
Where we pass filterBy=MEMBERS, filterBy=AO or role=ARCHIVED, role=NEW, with paginations
|
Can you please share the data model and API contracts for it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1000