feat:add taskTitle field to sendTaskUpdate util (#2029)

Co-authored-by: Amit Prakash <[email protected]>
Real-Dev-Squad · May 5, 2024 · 60ef429 · 60ef429
1 parent 4342eb6
commit 60ef429
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 7 deletions.
diff --git a/controllers/progresses.js b/controllers/progresses.js
@@ -49,8 +49,8 @@ const createProgress = async (req, res) => {
  body: { type, completed, planned, blockers, taskId },
  } = req;
  try {
- const data = await createProgressDocument({ ...req.body, userId: req.userData.id });
- await sendTaskUpdate(completed, blockers, planned, req.userData.username, taskId);
+ const { data, taskTitle } = await createProgressDocument({ ...req.body, userId: req.userData.id });
+ await sendTaskUpdate(completed, blockers, planned, req.userData.username, taskId, taskTitle);
  return res.status(201).json({
  data,
  message: `${type.charAt(0).toUpperCase() + type.slice(1)} ${PROGRESS_DOCUMENT_CREATED_SUCCEEDED}`,

diff --git a/models/progresses.js b/models/progresses.js
@@ -25,8 +25,9 @@ const createProgressDocument = async (progressData) => {
  const { type, taskId } = progressData;
  const createdAtTimestamp = new Date().getTime();
  const progressDateTimestamp = getProgressDateTimestamp();
+ let taskTitle;
  if (taskId) {
- await assertTaskExists(taskId);
+ taskTitle = await assertTaskExists(taskId);
  }
  const query = buildQueryForPostingProgress(progressData);
  const existingDocumentSnapshot = await query.where("date", "==", progressDateTimestamp).get();
@@ -35,7 +36,8 @@ const createProgressDocument = async (progressData) => {
  }
  const progressDocumentData = { ...progressData, createdAt: createdAtTimestamp, date: progressDateTimestamp };
  const { id } = await progressesCollection.add(progressDocumentData);
- return { id, ...progressDocumentData };
+ const data = { id, ...progressDocumentData };
+ return { data, taskTitle };
 };
 
 /**

diff --git a/test/unit/utils/sendTaskUpdate.test.js b/test/unit/utils/sendTaskUpdate.test.js
@@ -22,7 +22,8 @@ describe("sendTaskUpdate function", function () {
  "No blockers",
  "Plan for the next phase",
  "userName",
- "taskId"
+ "taskId",
+ "Task title"
  );
  expect(result).to.equal(undefined);
  });
@@ -31,7 +32,14 @@ describe("sendTaskUpdate function", function () {
  const error = new Error("Error");
  fetchMock.rejects(error);
  try {
- await sendTaskUpdate("Task completed", "No blockers", "Plan for the next phase", "userName", "taskId");
+ await sendTaskUpdate(
+ "Task completed",
+ "No blockers",
+ "Plan for the next phase",
+ "userName",
+ "taskId",
+ "task title"
+ );
  } catch (err) {
  expect(err).to.be.equal(error);
  }

diff --git a/utils/progresses.js b/utils/progresses.js
@@ -69,6 +69,7 @@ const assertTaskExists = async (taskId) => {
  if (!taskData) {
  throw new NotFound(`Task with id ${taskId} does not exist.`);
  }
+ return taskData;
 };
 
 /**

diff --git a/utils/sendTaskUpdate.js b/utils/sendTaskUpdate.js
@@ -1,7 +1,7 @@
 import { generateCloudFlareHeaders } from "../utils/discord-actions.js";
 const DISCORD_BASE_URL = config.get("services.discordBot.baseUrl");
 
-export const sendTaskUpdate = async (completed, blockers, planned, userName, taskId) => {
+export const sendTaskUpdate = async (completed, blockers, planned, userName, taskId, taskTitle) => {
  try {
  const headers = generateCloudFlareHeaders();
  const body = {
@@ -11,6 +11,7 @@ export const sendTaskUpdate = async (completed, blockers, planned, userName, tas
  planned,
  userName,
  taskId,
+ taskTitle,
  },
  };
  await fetch(`${DISCORD_BASE_URL}/task/update`, {