Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the header to passed down the API #186

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

skv93-coder
Copy link
Contributor

@skv93-coder skv93-coder commented Jan 13, 2024

Date: 13-Jan-23

Developer Name: @skv93-coder


Issue Ticket Number

#167

Description

This PR enables it to pass reason in audit logs

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1 Without supplying header the header is not passed down to the discord.
screen-capture.1.webm

-When supplying header the header is passed down to the discord.

screen-capture.2.webm

Test Coverage

Screenshot 1

Screenshot from 2024-01-13 21-00-40
Screenshot from 2024-01-13 23-36-47

Additional Notes

Copy link

@ajoykumardas12 ajoykumardas12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
But I don't have experience with Discord API, please get more approval.

Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test case status

@iamitprakash iamitprakash merged commit fc35ed4 into develop Jan 17, 2024
2 checks passed
@iamitprakash iamitprakash deleted the feature/enable-audit-logs branch January 17, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants