Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix window (boundary, start/end) cancel and abandonment #6762

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

akarnokd
Copy link
Member

This PR fixes the window operator (with boundary and start-end sources) so that

  • cancelling the inner windows allows cancelling the upstream once neither the main output nor other windows are being consumed further,
  • ignoring a window still allows cancelling the upstream.

Follow-up to #6758 and #6761

@akarnokd akarnokd added this to the 3.0 milestone Dec 16, 2019
@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #6762 into 3.x will increase coverage by 0.06%.
The diff coverage is 95.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6762      +/-   ##
============================================
+ Coverage     98.16%   98.22%   +0.06%     
+ Complexity     6196     6195       -1     
============================================
  Files           679      679              
  Lines         44552    44622      +70     
  Branches       6145     6138       -7     
============================================
+ Hits          43734    43832      +98     
+ Misses          296      275      -21     
+ Partials        522      515       -7
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <ø> (ø) 559 <0> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <ø> (ø) 537 <0> (ø) ⬇️
...operators/observable/ObservableWindowBoundary.java 99.22% <100%> (+0.01%) 2 <0> (ø) ⬇️
...nal/operators/flowable/FlowableWindowBoundary.java 99.28% <100%> (+0.02%) 2 <0> (ø) ⬇️
...ators/flowable/FlowableWindowBoundarySelector.java 95.23% <94.82%> (+4.27%) 2 <0> (ø) ⬇️
...s/observable/ObservableWindowBoundarySelector.java 96.42% <96.34%> (+4.86%) 2 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...eactivex/rxjava3/processors/BehaviorProcessor.java 96.58% <0%> (-2.44%) 51% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 90.47% <0%> (-2.39%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 90.14% <0%> (-1.41%) 2% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daeccff...c1cd03f. Read the comment docs.

@akarnokd akarnokd merged commit f96821f into ReactiveX:3.x Dec 17, 2019
@akarnokd akarnokd deleted the WindowBoundaryCancelFix3x branch December 17, 2019 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant