3.x: Fix groupBy not canceling upstream due to group abandonment #6642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue when a group is not subscribed to, the upstream may never cancel due to seemingly open groups.
The fix is a tradeoff with group abandonment and possible excessive group re-creation so that elements are not lost in case the groups do get subscribed to a bit later. Therefore, the groups should be subscribed to immediately and synchronously:
Consequently, the following setups will result in constant group recreations:
For the
subscribeOn
"trouble", since groups were essentially unicast subjects/processors,subscribeOn
had no practical use on them and insteadobserveOn
should be used to move the observation of the group's items to the desired thread.Resolves #6596