feat(Google News): Add Enable CustomTabs and GmsCore support patch
#3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
depends on this pullrequest in revanced-integrations: otherwise i get an error in the onCreate method of StartActivity |
oSumAtrIX
requested changes
May 2, 2024
...in/kotlin/app/revanced/patches/magazines/customtabs/fingerprints/UseCustomTabsFingerprint.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/app/revanced/patches/magazines/customtabs/fingerprints/UseCustomTabsFingerprint.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/magazines/misc/gms/ClientSpoofPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/magazines/misc/gms/ClientSpoofPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/magazines/misc/gms/ClientSpoofPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/magazines/misc/gms/GmsCoreSupportPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/magazines/misc/gms/GmsCoreSupportPatch.kt
Outdated
Show resolved
Hide resolved
...pp/revanced/patches/magazines/misc/integrations/fingerprints/StartActivityInitFingerprint.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/shared/misc/gms/BaseGmsCoreSupportPatch.kt
Outdated
Show resolved
Hide resolved
added 2 commits
May 3, 2024 18:53
oSumAtrIX
reviewed
May 25, 2024
src/main/kotlin/app/revanced/patches/magazines/customtabs/UseCustomTabs.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
May 25, 2024
...in/kotlin/app/revanced/patches/magazines/customtabs/fingerprints/UseCustomTabsFingerprint.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
May 25, 2024
...in/kotlin/app/revanced/patches/magazines/customtabs/fingerprints/UseCustomTabsFingerprint.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
May 25, 2024
.../kotlin/app/revanced/patches/magazines/misc/gms/fingerprints/GooglePlayUtilityFingerprint.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
requested changes
May 25, 2024
...pp/revanced/patches/magazines/misc/integrations/fingerprints/StartActivityInitFingerprint.kt
Outdated
Show resolved
Hide resolved
...pp/revanced/patches/magazines/misc/integrations/fingerprints/StartActivityInitFingerprint.kt
Outdated
Show resolved
Hide resolved
...pp/revanced/patches/magazines/misc/integrations/fingerprints/StartActivityInitFingerprint.kt
Outdated
Show resolved
Hide resolved
|
@benjy3gg Is this PR still active? |
oSumAtrIX
reviewed
Jun 7, 2024
| @Patch(requiresIntegrations = true) | ||
| object IntegrationsPatch : BaseIntegrationsPatch( | ||
| setOf( | ||
| StartActivityInitFingerprint |
There was a problem hiding this comment.
Are there any other exported activities that can be launched? Because if so, they should be added here because if they are launched, context would not be hooked.
oSumAtrIX
changed the title
Enable CustomTabs and GmsCore support patch
|
The GmsCore patch crashes the app. changing register to v2 in this line of the decompiled patched app fixes the crash invoke-static/range {v3 .. v3}, Lapp/revanced/integrations/shared/Utils;->setContext(Landroid/content/Context;)V |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Patch implements CustomTabs in Google News (com.google.android.apps.magazines).
This sets a flag that is otherwise false to true -> Instead of opening articles in ChromeWebView it uses the Default Browser
This also implements Basic GMSCore Support.
Login and Logout works.
Clicking on "Manager your Google Account" doesn't open the GMSCore settings -> same problem as in Youtube.