Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Rarity Skin #116

Merged
merged 6 commits into from
Nov 22, 2021
Merged

Feature/Rarity Skin #116

merged 6 commits into from
Nov 22, 2021

Conversation

Majorfi
Copy link
Contributor

@Majorfi Majorfi commented Nov 22, 2021

Description

Add support for Rarity Skin.
Replace #108 and close #100.
The skin option is enable by default and can be toggle on the option modal.
There is currently no way to buy/set a skin for an adventurer from Rarity Extended.

Also provide some change on the data fetching and handling, using IndexDB to store some element to load a LOT faster.

Type of change

  • New feature (non-breaking change which adds functionality)

Change details

  • Add a new skin option in useUI.
  • Add a condition to use Rarity Skin instead of default skin is the option is selected.
  • Add indexDB to keep data in local db.
  • Start an upgrade of data handling in useRarity.

Resources

Capture d’écran 2021-11-22 à 14 10 39

@Majorfi Majorfi added the enhancement New feature or request label Nov 22, 2021
@vercel
Copy link

vercel bot commented Nov 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rarityextended/rarity/CUFwUws5C28eQx5EqBk42w5hN5V5
✅ Preview: https://rarity-git-feature-rarityskin-rarityextended.vercel.app

@Majorfi
Copy link
Contributor Author

Majorfi commented Nov 22, 2021

Has been checked by the Rarity Skin team!

@Majorfi Majorfi merged commit 6380b81 into main Nov 22, 2021
@Majorfi Majorfi deleted the feature/rarityskin branch November 22, 2021 18:48
@Majorfi Majorfi mentioned this pull request Nov 22, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Implement rarity-skin
2 participants