Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requests Template #101

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Conversation

hanahem
Copy link
Contributor

@hanahem hanahem commented Oct 15, 2021

Description

It is more optimal to have a PR template for better communication on contributions.
The template will be set by default when opening a PR, so it is easy to fill in the info.
Said template is used in this PR.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Other

Change details

Adds a pull_request_template.md file to the project's root.

@vercel
Copy link

vercel bot commented Oct 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rarityextended/rarity/61XguAUJshfYRidb24giyRNY7Hp7
✅ Preview: https://rarity-git-fork-hanahem-feature-pr-template-rarityextended.vercel.app

Copy link
Contributor

@Majorfi Majorfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Cool stuff, I tried to setup this but the template was never displayed

@Majorfi Majorfi self-assigned this Oct 15, 2021
@Majorfi Majorfi added the enhancement New feature or request label Oct 15, 2021
@Majorfi Majorfi added this to In Progress in Rarity Extended via automation Oct 15, 2021
@Majorfi Majorfi moved this from In Progress to To Review in Rarity Extended Oct 15, 2021
@Majorfi Majorfi merged commit bf6fd24 into Rarity-Extended:main Oct 15, 2021
Rarity Extended automation moved this from To Review to Done Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants