Store app command ids on CommandTree #9924
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCausc78
reviewed
Aug 18, 2024
|
I'm not sure I follow the reasoning for this existing since users can specify their own tree class, this is something users could implement without it needing to be extra objects stored for all users of command tree. Or if an implementation which caches this is going to exist in the library, it could be a subclass that's available for users to opt-into. other more nit-feedback was already mentioned in discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As it was desired, I have written an implementation that stores app command ids on the CommandTree and keeps them updated via sync, fetch and on callback. Also added two new methods to get the ID and return the mention format.
Currently as a draft because I am not sure if the current impl is the best way to this and would like some feedback on it, ignoring the left over comments/methods but it does work.
Checklist