Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for get voice state #9908

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

Puncher1
Copy link
Contributor

@Puncher1 Puncher1 commented Aug 7, 2024

Summary

This PR adds the functionality to get the voice state over the http endpoints.

Related PR:

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@chredeur
Copy link

It would be nice to merge this functionality 😅

Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear from the documentation what would happen if the member does not have a voice state. I'm assuming it returns a 404, but I'm not at liberty to test.

@MCausc78
Copy link

It's not clear from the documentation what would happen if the member does not have a voice state. I'm assuming it returns a 404, but I'm not at liberty to test.

Yes, it returns 404 with "Unknown Voice State" message.

@Puncher1
Copy link
Contributor Author

Puncher1 commented Aug 28, 2024

It's not clear from the documentation what would happen if the member does not have a voice state. I'm assuming it returns a 404, but I'm not at liberty to test.

Yes it does

image

@Rapptz
Copy link
Owner

Rapptz commented Aug 28, 2024

Should probably add that to the Raises section then.

@Puncher1 Puncher1 requested a review from Rapptz August 28, 2024 20:12
@Rapptz Rapptz merged commit 62e5280 into Rapptz:master Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants