Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_localizations to CommandTree.fetch_commands #9452

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented Jun 13, 2023

Summary

This PR adds a kwarg called with_localizations to CommandTree.fetch_commands and relevant HTTP methods.

This allows for fetching app commands localization strings.

Relevant API Docs:

Post in server: https://discord.com/channels/336642139381301249/1118119655719043072

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Soheab Soheab changed the title Add with_localizations to CommandTree.fetch_commands Add with_localizations to CommandTree.fetch_commands Jun 13, 2023
@Soheab Soheab changed the title Add with_localizations to CommandTree.fetch_commands Add with_localizations to CommandTree.fetch_commands Jun 13, 2023
@Soheab
Copy link
Contributor Author

Soheab commented Jun 14, 2023

Needs testing. done

@Soheab Soheab marked this pull request as draft June 14, 2023 11:19
@Soheab Soheab marked this pull request as ready for review June 14, 2023 13:13
@staciax
Copy link

staciax commented Apr 12, 2024

🥺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants