Support Guild Onboarding #9260
Support Guild Onboarding #9260
Conversation
Co-authored-by: numbermaniac <[email protected]>
Co-authored-by: numbermaniac <[email protected]>
|
A few fields are missing, which I get: "enable_default_channels": true,
"enable_onboarding_prompts": true,
"onboarding_prompts_seen": {},
"onboarding_responses_seen": {},
"responses": []This would belong to |
|
The guild features could be added to this PR too:
Also the audit log events: discord/discord-api-docs#6041 |
|
The fields of the prompt option have changed: discord/discord-api-docs#6479 Looks like the emoji isn't implemented at all for editing yet. |
|
The name of some audit log actions have changed and 2 new actions have been added, see discord/discord-api-docs#6041 I think it doesn't make sense to change the name of the server guide actions too, because the description kept the same and so the current names are more meaningful. |
| class Onboarding(TypedDict): | ||
| guild_id: Snowflake | ||
| prompts: list[Prompt] | ||
| default_channel_ids: list[Snowflake] |
There was a problem hiding this comment.
| default_channel_ids: list[Snowflake] | |
| default_channel_ids: List[Snowflake] |
|
|
||
| class Onboarding(TypedDict): | ||
| guild_id: Snowflake | ||
| prompts: list[Prompt] |
There was a problem hiding this comment.
| prompts: list[Prompt] | |
| prompts: List[Prompt] |
|
|
||
| class Prompt(TypedDict): | ||
| id: Snowflake | ||
| options: list[PromptOption] |
There was a problem hiding this comment.
| options: list[PromptOption] | |
| options: List[PromptOption] |
| class PromptOption(TypedDict): | ||
| id: Snowflake | ||
| channel_ids: list[Snowflake] | ||
| role_ids: list[Snowflake] |
There was a problem hiding this comment.
| role_ids: list[Snowflake] | |
| role_ids: List[Snowflake] |
|
|
||
| class PromptOption(TypedDict): | ||
| id: Snowflake | ||
| channel_ids: list[Snowflake] |
There was a problem hiding this comment.
| channel_ids: list[Snowflake] | |
| channel_ids: List[Snowflake] |
|
|
||
| from __future__ import annotations | ||
|
|
||
| from typing import Literal, Optional, TypedDict |
There was a problem hiding this comment.
| from typing import Literal, Optional, TypedDict | |
| from typing import Literal, Optional, TypedDict, List |
| def __init__( | ||
| self, | ||
| title: str, | ||
| emoji: Union[Emoji, PartialEmoji, str], |
There was a problem hiding this comment.
Docstring marks this as optional.
| emoji: Union[Emoji, PartialEmoji, str], | |
| emoji: Optional[Union[Emoji, PartialEmoji, str]], |
| ) -> None: | ||
| self.title: str = title | ||
| self.description: Optional[str] = description | ||
| self.emoji: Union[PartialEmoji, Emoji, str] = emoji |
There was a problem hiding this comment.
This should be parsing strs into PartialEmojis.
| self.emoji: Union[PartialEmoji, Emoji, str] = emoji | |
| self.emoji: Optional[Union[PartialEmoji, Emoji]] = PartialEmoji.from_str(emoji) if isinstance(emoji, str) else emoji |
| self.channel_ids: Set[int] = set(channel_ids or []) | ||
| self.role_ids: Set[int] = set(role_ids or []) | ||
|
|
||
| def to_dict(self, *, id: int = MISSING) -> PromptOptionPayload: |
There was a problem hiding this comment.
This should also be updated for the change, using self.emoji._to_partial then handling the rest
| } | ||
|
|
||
| return { | ||
| 'id': id or os.urandom(16).hex(), |
There was a problem hiding this comment.
Wouldn't this be always MISSING when no value is passed🤔? Shouldn't this be a id if id is not MISSING else os.urandom(16).hex()?
Summary
This pull request implements support for the guild onboarding configuration.
Checklist