-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for command argument separators. #2485
Open
NCPlayz
wants to merge
13
commits into
Rapptz:master
Choose a base branch
from
NCPlayz:v1/ext/commands/separator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+236
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple502j
reviewed
Dec 22, 2019
Rapptz
requested changes
Apr 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly fine aside from the questions I poised down there.
I'm going to slate this for 1.4 release so if you could add those versionadded tags I'd be grateful.
Rapptz
force-pushed
the
v1/ext/commands/separator
branch
from
July 24, 2020 13:37
391788a
to
b35070e
Compare
Rapptz
requested changes
Jul 25, 2020
3 tasks
NCPlayz
force-pushed
the
v1/ext/commands/separator
branch
from
June 3, 2021 17:20
630e211
to
9d45cbc
Compare
NCPlayz
force-pushed
the
v1/ext/commands/separator
branch
from
August 27, 2021 11:54
b023d65
to
11ffb1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an adaptation of the now defunct PR - #645. It allows for two ways of command customization:
?foo a b, c, d, e
->('a b', 'c', 'd', 'e')
?bar a b [c d e] f g
->('a', 'b', 'c d e', 'f', 'g')
As this changes quite a bit of the parsing of commands behind the scenes, I will try to test this as extensively as possible before marking it ready for review.
Improvement list
c.isspace
instead of hardcoded space checkChecklist