Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic tutorial for HelpCommand. #2017

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NCPlayz
Copy link
Contributor

@NCPlayz NCPlayz commented Mar 22, 2019

Summary

This PR was made to add a tutorial for HelpCommand and the like. I'm sure there's many issues with this, but I just wanted to get this out so that it can be reviewed, and so that I can improve it.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Update

03/04/2019 20:14 : This probably won't get done for at least another week. Sorry!

Copy link
Contributor

@laggycomputer laggycomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the aim of this, but I'm a grammar nitpicker.

docs/ext/commands/help.rst Outdated Show resolved Hide resolved
docs/ext/commands/help.rst Outdated Show resolved Hide resolved
docs/ext/commands/help.rst Outdated Show resolved Hide resolved
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs work.

=================

The simplicity of :class:`~.commands.HelpCommand` allows you to customise
your experience very easily.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence seems like it belongs somewhere explaining how to do custom commands. Which... this does not do. Probably re-order the entire structure. To something like this:

  1. Using The Help Command
    • Probably talk about the interface of the actual help command
      show examples etc
    • Talk about the sending help with ctx here
  2. Replacing The Help Command
    • Talk about how you can set bot.help_command
      • This would be a good time to show commands.MinimalHelpCommand
    • Talk about how you can do bot.help_command.cog = ...
  3. Writing A Help Command
    • Talk about the steps to write your own custom help
    • Describe all of the member functions required to make a help command and walk through the steps together

This is what I had in mind as a rough idea. Documentation of prose pages requires planning and working with flow so the contents are coherent instead of random paragraphs.

docs/ext/commands/help.rst Outdated Show resolved Hide resolved
docs/ext/commands/help.rst Outdated Show resolved Hide resolved
docs/ext/commands/help.rst Outdated Show resolved Hide resolved
docs/ext/commands/help.rst Outdated Show resolved Hide resolved
docs/ext/commands/help.rst Outdated Show resolved Hide resolved
docs/ext/commands/help.rst Outdated Show resolved Hide resolved
docs/ext/commands/help.rst Outdated Show resolved Hide resolved
@NCPlayz NCPlayz changed the base branch from rewrite to master April 8, 2019 23:01
@NCPlayz NCPlayz marked this pull request as ready for review April 18, 2019 21:58
@Rapptz Rapptz added the needs review This PR will be reviewed in the future label May 9, 2019
@NCPlayz NCPlayz marked this pull request as draft March 28, 2021 21:31
@wasi-master
Copy link

wasi-master commented Aug 15, 2021

what happened to this?

@Gobot1234
Copy link
Contributor

It will be left until the help command redesign is finished

@JDJGInc
Copy link
Contributor

JDJGInc commented Oct 10, 2022

Is this still being worked on?
or will it be updated if Danny works on a help command update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review This PR will be reviewed in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants