-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic tutorial for HelpCommand. #2017
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the aim of this, but I'm a grammar nitpicker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs work.
docs/ext/commands/help.rst
Outdated
================= | ||
|
||
The simplicity of :class:`~.commands.HelpCommand` allows you to customise | ||
your experience very easily. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence seems like it belongs somewhere explaining how to do custom commands. Which... this does not do. Probably re-order the entire structure. To something like this:
- Using The Help Command
- Probably talk about the interface of the actual help command
show examples etc - Talk about the sending help with ctx here
- Probably talk about the interface of the actual help command
- Replacing The Help Command
- Talk about how you can set
bot.help_command
- This would be a good time to show
commands.MinimalHelpCommand
- This would be a good time to show
- Talk about how you can do
bot.help_command.cog = ...
- Talk about how you can set
- Writing A Help Command
- Talk about the steps to write your own custom help
- Describe all of the member functions required to make a help command and walk through the steps together
This is what I had in mind as a rough idea. Documentation of prose pages requires planning and working with flow so the contents are coherent instead of random paragraphs.
84b17a0
to
1db966b
Compare
Co-authored-by: James <[email protected]>
071c797
to
c4f52fc
Compare
what happened to this? |
It will be left until the help command redesign is finished |
Is this still being worked on? |
Summary
This PR was made to add a tutorial for HelpCommand and the like. I'm sure there's many issues with this, but I just wanted to get this out so that it can be reviewed, and so that I can improve it.
Checklist
Update
03/04/2019 20:14 : This probably won't get done for at least another week. Sorry!