Removes System.Drawing from IdSharp.Tagging #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coupling this library with System.Drawing for one use case is unnecessary, especially when many libraries have gone to great pains to remove System.Drawing form their stacks. This commit moves the System.Drawing parts of AttachedPicture into a separate project so that those references do not pollute the main library. More work is needed to, especially in deciding whether or not to keep the AttachedPictureWithImage class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Please excuse the direct PR but I figured it was easier to submit a patch with the work done (and to change it if necessary) rather than explain this in an issue.
When installing this library via nuget, it also attempt to install System.Drawing (and System.Win32.Events):
Coupling this library with System.Drawing for one use case is unnecessary, especially when many libraries have gone to great pains to remove System.Drawing form their stacks.
This commit moves the System.Drawing parts of AttachedPicture into a separate project so that those references do not pollute the main library.
More work is needed to, especially in deciding whether or not to keep the AttachedPictureWithImage class and possibly publishing a new nuget package as well.
What do you think?