Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocompilation after push with GitHub Actions #576

Merged
merged 31 commits into from
Feb 9, 2020
Merged

Add autocompilation after push with GitHub Actions #576

merged 31 commits into from
Feb 9, 2020

Conversation

playday3008
Copy link
Contributor

If you want, you can merge this to autocompile your project automatically

@Ralim
Copy link
Owner

Ralim commented Feb 7, 2020

Hi, I'm already using codeship to automatically build the project and notify me if builds fail.
What would the benefit be here to use this instead?

@Ralim
Copy link
Owner

Ralim commented Feb 9, 2020

Hi, if you could clean this up to not run the ls command or to upload artifacts by default this could be interesting to test. Have you been running it on other repositories?

@playday3008 playday3008 closed this Feb 9, 2020
@playday3008
Copy link
Contributor Author

Hi, if you could clean this up to not run the ls command or to upload artifacts by default this could be interesting to test. Have you been running it on other repositories?

I have 8 repos with autocompilation, I fork your repo because I want to fix Ukrainian language and autocompile firmware, I don't want to install dependencies and WSL or linux, to compile firmware on my PC

@playday3008
Copy link
Contributor Author

if you want autocompilation without my tries (commits), just copy this file https://github.com/playday3008/ts100/blob/master/.github/workflows/ccpp.yml to you repo

@playday3008
Copy link
Contributor Author

And, if someone do pull request to you repo, GitHub automatically try to compile your code with changes from request, and check compatibility

@playday3008
Copy link
Contributor Author

playday3008 commented Feb 9, 2020

Ex. https://github.com/android-hacker/VirtualXposed/pull/798/checks
I create pull request, and GitHub automatically try compile

@playday3008
Copy link
Contributor Author

What would the benefit be here to use this instead?

Anyone can check compilation status, and anyone can check pull request compatibility

@playday3008 playday3008 reopened this Feb 9, 2020
@Ralim
Copy link
Owner

Ralim commented Feb 9, 2020

Ah okay so this does do the same thing as my gitlab and codeship stuff but just publicly 😅

I'm not against your commits just checking I understand if it's doing anything odd or extra.

I will merge this if your happy with it (noting a lot of edits) 😅

Happy to add extra CI, it's always good :)

@Ralim Ralim merged commit e0cc415 into Ralim:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants