resolves #345 #352
Merged
resolves #345 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
finanalyst
commented
Mar 21, 2024
- Indexed data is automatically collected, but was not used in the original website. I think this was a mistake.
- Not all pages have much indexing, but recently Issue Add <-> (for class Block rw signature introducer) to Search box doc#4440 shows that there is room for more.
- I have been running this patch on new-raku, and it is fairly useful on pages like new-raku operators
- Indexed data is automatically collected, but was not used in the original website. I think this was a mistake. - Not all pages have much indexing, but recently Issue #350 shows that there is room for more. - I have been running this patch on new-raku, and it is fairly useful on pages like [new-raku operators](https://new-raku.finanalyst.org/language/operators)
|
@dontlaugh this patch failed on the second buildkite, but not because of the CSS changes (I think). |
coke
approved these changes
Mar 21, 2024
dontlaugh
approved these changes
Mar 21, 2024
|
I usually amend the commit and (carefully) force push. The failure seems transient so this is good to go, imo https://buildkite.com/raku/doc-website/builds/4552#018e612d-6994-453e-8cf4-7da1a73cd09b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.