Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighted the active menu item in navbar #1567

Closed
wants to merge 0 commits into from

Conversation

KajalBhatt123
Copy link
Contributor

@KajalBhatt123 KajalBhatt123 commented Jul 7, 2024

Fixes Issue🛠️

Closes #1503

Description👨‍💻

When hovering over the navigation links (Home, About, Calculators etc.), the link color change, but the color reverts to white, making it indistinguishable from inactive links. Thus, made changes to highlight the current link.

Type of Change📄

  • Style (non-breaking change which improves website style or formatting)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

Untitled.video.-.Made.with.Clipchamp.mp4

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KajalBhatt123, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Jul 7, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 5588f2d
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/6690d59bf0861100082caf40
😎 Deploy Preview https://deploy-preview-1567--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100 Rakesh9100 changed the title highlighting active menu Highlighted the active menu item of navbar Jul 12, 2024
@Rakesh9100
Copy link
Owner

Why so many extra formatting or indentation changes are there, just keep your codes in this PR else no other modification @KajalBhatt123

For example:

image

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jul 12, 2024
@Rakesh9100 Rakesh9100 removed the question 🤔 Further information is requested label Jul 12, 2024
@Rakesh9100 Rakesh9100 changed the title Highlighted the active menu item of navbar Highlighted the active menu item in navbar Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] Highlight the active menu item in navbar
2 participants