Upgrade to avr-device 0.3 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we'll get duplicated jobs for local branches which are also used in a pull request.
With avr-device the names for the SPI clock rates were updated. Reflect this update in the HAL as well to make it compile with the new version.
The previous code was based on the incorrect PAC enum which contained enumerated values which actually do not fit the field they were specified for. As those were removed in avr-device 0.3, this implmentation here also no longer compiles. Instead, use a similar approach to the atmega32u4-hal where a custom `AdcMux` enum is defined which we use to represent all supported MUX values in a compact way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.