Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/ Clean up redundancies #63

Merged
merged 3 commits into from
Jan 15, 2024
Merged

feature/ Clean up redundancies #63

merged 3 commits into from
Jan 15, 2024

Conversation

SimonDarksideJ
Copy link
Collaborator

Description

Clean up redundant code in the Rest Library:

  • Unnecessary #if UNITY statements (identical code)
  • Remove Obsolete functions (actually caused duplicate signature issues)

StephenHodgson
StephenHodgson requested changes Jan 6, 2024
View reviewed changes
Copy link
Member

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but missing version changes

@SimonDarksideJ SimonDarksideJ changed the base branch from main to development January 6, 2024 17:58
@StephenHodgson StephenHodgson merged commit b82d7cb into RageAgainstThePixel:development Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenHodgson StephenHodgson StephenHodgson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimonDarksideJ @StephenHodgson