fix: use ValueError instead of assert
on argument checks
#164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a small issue on script
python/merge_lora_into_ggml.py
.Program should always fail if
arch_version
or data format does not satisfy the preconditions in the program. However, the filemerge_lora_into_ggml.py
usesassert
statements, sometimes being ignored under high optimization level. We usesif
-statements here, where those preconditions would always execute, whether the environment enable assert stateuements or not.Ref: https://stackoverflow.com/questions/61826628/what-is-the-advantage-if-any-of-using-assert-over-an-if-else-condition . Here, our checks are still in effect when
-O
flag is enabled, soif __debug__:
(implied inassert
statements) is not necessary.