Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【修复】修复ART-PI samrt上读取不到emmc/sd分区问题 #9051

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

zhuzhuzhus
Copy link
Contributor

@zhuzhuzhus zhuzhuzhus commented Jun 11, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

在ART-PI上移植rtthread的时候,发现最新主线上的内核读取不到emmc和sd的分区,经过回退代码确认,发现是这一次的提交导致了该问题:
#8987
经过调试发现之前版本中是先初始化总线时钟频率再初始化总线宽度,这次得修改中将顺序反过来了,导致读取不到emmc/sd分区(但是为什么在其他板子上可以读取?),在网上查阅资料发现带宽得初始化一般都是放在最后面(可以保证配置的一致性和稳定性?)。

你的解决方案是什么 (what is your solution)

将初始化时钟频率放在初始化带宽前面

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@zhuzhuzhus zhuzhuzhus closed this Jun 11, 2024
@zhuzhuzhus zhuzhuzhus reopened this Jun 11, 2024
@helloeagleyang
Copy link
Contributor

helloeagleyang commented Jun 11, 2024

您提及的导致问题的那个patch在ART-Pi上测试并没有问题,SD和eMMC的连接都是正常的,测试结果如下图所示:
emmc_artpi
sd_artpi

@zhuzhuzhus
Copy link
Contributor Author

在ART-Pi上测试过这个改动,SD和eMMC的连接都是正常的,测试结果如下图所示: emmc_artpi sd_artpi

下面的emmc分区正确识别出来了嘛,我看图片上没有打印,然后我这边测试的是ART-PI smart的板子,是imx6ull的版本,可能和STM32的哪个ART-PI现象不太一样欸

@zhuzhuzhus zhuzhuzhus changed the title 【修复】修复ART-PI上读取不到emmc/sd分区问题 【修复】修复ART-PI samrt上读取不到emmc/sd分区问题 Jun 12, 2024
@helloeagleyang
Copy link
Contributor

在ART-Pi上测试过这个改动,SD和eMMC的连接都是正常的,测试结果如下图所示: emmc_artpi sd_artpi

下面的emmc分区正确识别出来了嘛,我看图片上没有打印,然后我这边测试的是ART-PI smart的板子,是imx6ull的版本,可能和STM32的哪个ART-PI现象不太一样欸

识别出来了

@BernardXiong
Copy link
Member

在ART-Pi上测试过这个改动,SD和eMMC的连接都是正常的,测试结果如下图所示: emmc_artpi sd_artpi

Thank you for your feedback.

@BernardXiong BernardXiong merged commit 1b4b338 into RT-Thread:master Jun 12, 2024
46 checks passed
@helloeagleyang
Copy link
Contributor

在ART-Pi上测试过这个改动,SD和eMMC的连接都是正常的,测试结果如下图所示: emmc_artpi sd_artpi

Thank you for your feedback.

熊大,弄混了,我是说之前他提及的那个patch我在Art-Pi上测试没问题,不是说他当前的这个patch

@BernardXiong
Copy link
Member

在ART-Pi上测试过这个改动,SD和eMMC的连接都是正常的,测试结果如下图所示: emmc_artpi sd_artpi

Thank you for your feedback.

熊大,弄混了,我是说之前他提及的那个patch我在Art-Pi上测试没问题,不是说他当前的这个patch

呃,那么现在这样的修改呢?

@helloeagleyang
Copy link
Contributor

在ART-Pi上测试过这个改动,SD和eMMC的连接都是正常的,测试结果如下图所示: emmc_artpi sd_artpi

Thank you for your feedback.

熊大,弄混了,我是说之前他提及的那个patch我在Art-Pi上测试没问题,不是说他当前的这个patch

呃,那么现在这样的修改呢?

这样改完后,SD3.0的功能就被干掉了

@zhuzhuzhus
Copy link
Contributor Author

在ART-Pi上测试过这个改动,SD和eMMC的连接都是正常的,测试结果如下图所示: emmc_artpi sd_artpi

Thank you for your feedback.

熊大,弄混了,我是说之前他提及的那个patch我在Art-Pi上测试没问题,不是说他当前的这个patch

呃,那么现在这样的修改呢?

#9058 这个pr修改应该是正常的了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants