Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serial]: 增加超时事件处理 #8145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meng-plus
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

#8143

你的解决方案是什么 (what is your solution)

完善rt_hw_serial_isr的事件分支

在什么测试环境下测试通过 (what is the test environment)

lpc4088 iar8_40 个人项目中测试通过
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@meng-plus
Copy link
Contributor Author

使用演示

static rt_err_t finsh_rx_ind(rt_device_t dev, rt_size_t size)
{
    rt_serial_t *serial = (rt_serial_t *)dev;
    if (dev != thread_dts.device)
    {
        return RT_EOK;
    }
    if (serial->event == RT_SERIAL_EVENT_RX_TIMEOUT)
    {
        if (dev->user_data == &thread_dts)
        {
            /* release semaphore to let finsh thread rx data */
            rt_sem_release(&thread_dts.rx_sem);
        }
    }
    return RT_EOK;
}


/*thread 超时等待*/
    if (RT_EOK != rt_sem_take(&thread_dts.rx_sem, 10000)) // RT_WAITING_FOREVER
    {
        continue;
    }
    uint16_t length = rt_device_read(thread_dts.device, -1, ctx->read_buf, ctx->read_bufsz);
    rt_device_write(thread_dts.device, 0, ctx->read_buf, length);
   LOG_D("%d-> %s", length, ctx->read_buf);

感觉缺少一个接收多少串口数据的读取接口,使用回调finsh_rx_ind(rt_device_t dev, rt_size_t size)有size返回,但是这里是中断不太方便做太多操作

@meng-plus meng-plus changed the title fix(drv_uart.c): 增加超时事件 [serial]: 增加超时事件处理 Oct 18, 2023
@@ -152,6 +152,8 @@ struct rt_serial_device
void *serial_rx;
void *serial_tx;

rt_uint8_t event;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个变量拿出来之后,有人会用吗?如果有人用的话,就涉及到线程与中断的资源竞争了。

Copy link
Contributor Author

@meng-plus meng-plus Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finsh_rx_ind(rt_device_t dev, rt_size_t size)
用于在中断回调中 区分中断类型, 这部分用户自定以完善

暂时没有比放在这里更好的想法

超时事件在串行通信过程中能够更加高效简介的响应命令,我期望将此功能完善,对比逐个字节的接收事件,我认为降低频繁的切换将更加高效

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants